API review
Proposer: Tully Foote
Present at review:
- List reviewers
Question / concerns / comments
Enter your thoughts on the API and any questions / concerns you have here. Please sign your name. Anything you want to address in the API review should be marked down here before the start of the meeting.
API change
declare plugins using "package_name/class_name" instead of just "class_name"
This requires:
- switch to PLUGINLIB_DECLARE_CLASS(pkg, class_name, class_type, base_class_type)
- From PLUGINLIB_REGISTER_CLASS(class_name, class_type, base_class_type)
- xml plugin definitions use pkg/class_name
- dynamically loaded using "package_name/class_name" as class type
backwards compatability
- old macro is still there
- if you use it w/o the / syntax it will find the old style methods
Meeting agenda
To be filled out by proposer based on comments gathered during API review period
Conclusion
Package status change mark change manifest)
Action items that need to be taken.
Major issues that need to be resolved
try warning deprecation by empty deprecated function inside macro
- Otherwise good. Change docs with release.