rosgraph/Reviews/2009-12-30_Doc_Review
Reviewer:
- Jeremy
- Tim
Instructions for doing a doc review
See DocReviewProcess for more instructions
- Does the documentation define the Users of your Package, i.e. for the expected usages of your Stack, which APIs will users engage with?
- Are all of these APIs documented?
- Do relevant usages have associated tutorials? (you can ignore this if a Stack-level tutorial covers the relevant usage), and are the indexed in the right places?
- Is it clear to an outside user what the roadmap is for the Package?
- Is it clear to an outside user what the stability is for the Package?
- Are concepts introduced by the Package well illustrated?
Jeremy Leibs
- Does the documentation define the Users of your Package, i.e. for the expected usages of your Stack, which APIs will users engage with?
- Could maybe use comment about the fact that these are tools only and there is no programmatic API, etc. I'm fine without this, but I've seen it in other packages.
- Are all of these APIs documented?
- Command-line invocation of both tools is documented
- Do relevant usages have associated tutorials? (you can ignore this if a Stack-level tutorial covers the relevant usage), and are the indexed in the right places?
- Covered in ROS/Tutorials/UnderstandingTopics tutorial. Nothing fancy enough to warrant its own tutorial.
- Is it clear to an outside user what the roadmap is for the Package?
- Mentions rxgraph2 as future replacement
- Is it clear to an outside user what the stability is for the Package?
- Roadmap mentions that rxgraph will be phased out, but this is down at the bottom of the page. Maybe move to top of page?
- Are concepts introduced by the Package well illustrated?
- Nodes and Topics link to correct topics
Concerns / issues
- JL: Over all looks good.
- TF: Looks good to me too.
Conclusion
Doc reviewed