[Documentation] [TitleIndex] [WordIndex

API review

Reviewer: Radu

Question / concerns / comments

Disclaimer: My comments/issues are unordered, and I tend to jump from small to big things as I go through each file in the package. I tried to be as critical as possible in order to help push this thing through. Not all issues need to be addressed, and if some are harsher than needed, please just ignore them.

Conclusion

I did not check the usability of the classes and methods proposed in the API, as I assumed that the resultant driver nodes are working fine. I think we need to address a few of the issues mentioned above before release. The wiki pages are fantastic btw, abundant in information, so maybe taking a bit of that back to the code in a Doxygen fashion might be good.

In terms of the API however, I think that we will probably need to refactorize it once we have at least a few more similar camera drivers, so that they would share similar methods/attributes. Until then, I suppose that if whatever we have works, it should be good enough.



2022-05-28 13:08